Open
Conversation
mend-for-github-com
bot
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
penghuo,
ps48 and
seankao-az
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^20.0.0→^21.0.0By merging this PR, the below vulnerabilities will be automatically resolved:
Release Notes
jsdom/jsdom (jsdom)
v21.0.0Compare Source
A potentially-breaking bug fix:
window,document,location, andtopproperties ofWindowto be non-configurable. (@ExE-Boss)Other changes:
<input type=image>submitting forms. (@jenseng)locationsetter to theWindowobject, which forwards to thelocation.hrefsetter. Setting the URL is still only implemented for fragment navigations, however. (@ExE-Boss)defer=""<script>elements that are added afterDOMContentLoadedto execute, instead of being skipped.selectElement.selectedOptionsbeing incorrect whenoptionElement.selectedis set. This was a regression introduced in v20.0.1. Unfortunately this also reverts the performance improvement when appending<option>elements that was introduced then. (@eps1lon)self,locationbar,menubar,personalbar,scrollbars,statusbar,toolbar,frames,parent,external,length, andscreenproperties ofWindowto be replaceable: that is, setting them will override their values, instead of having the new value be ignored. (@ExE-Boss)JSDOM.fromURL()in the browser build of jsdom. (@LungZeno)